WoWCharacterStats: Midnight Season 1 Support#412
WoWCharacterStats: Midnight Season 1 Support#412bigsing wants to merge 1 commit intotronbyt:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the WoWCharacterStats application to incorporate support for the upcoming 'Midnight' expansion. By defining the current expansion and instance, the application is prepared to handle new game content and provide relevant statistics for players engaging with the latest World of Warcraft season. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new constants, CURRENT_EXPANSION and CURRENT_INSTANCE, intended for Midnight Season 1 support. However, these constants are not used in the application logic. The function responsible for calculating raid progress has not been updated to use these new constants, making the change incomplete.
| CURRENT_EXPANSION = "Midnight" | ||
| CURRENT_INSTANCE = "The Voidspire" |
There was a problem hiding this comment.
These constants are defined but are not used anywhere in the code. The get_raid_progress function still hardcodes "Current Season" to determine raid progress, instead of using the new CURRENT_EXPANSION constant. This leaves the implementation incomplete and introduces unused variables.
|
disregard |
1 participant
No description provided.